feat(ci): add cosign to sign the released binaries #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsturtevant
reviewed
Jan 30, 2024
Comment on lines
+79
to
+81
| make dist-${{ needs.parse.outputs.runtime }} | ||
| # Check if there's any files to archive as tar fails otherwise | ||
| if stat dist/bin/* >/dev/null 2>&1; then |
There was a problem hiding this comment.
What's the scenario where there are no files after running make dist-*
There was a problem hiding this comment.
You meant afer make build-*?
If we release containerd-shim-wasm-test-modules, I think there will be no files in disk/bin.
Sure, I also intend to add the verification doc on the release page. |
Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
|
@jeremyrickard could you please take a look? |
jsturtevant
reviewed
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR adds cosign signing for the released binaries. It is WIP.
I am testing releases in my own forked repo: https://github.com/Mossaka/runwasi/actions/runs/7634841458
Related to #417