-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bench): Re-enable cargo bench
#612
Conversation
The benchmarking in the CI finishes in 23 minutes. FWIW @jsturtevant |
benches/containerd-shim-benchmarks/benches/webassembly-benchmarks.rs
Outdated
Show resolved
Hide resolved
fad7e37
to
bae8997
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I'm going to take another look tomorrow if it hasn't been merged it yet.
Thanks for working on this!
This commit reverts back a change made by commit SHA 6882dd5 and fixed all the build errors for the benchmark. Closes containerd#611 Signed-off-by: jiaxiao zhou <[email protected]>
this commit adds a new github action that runs every Sunday to measure the benchmark Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wasi.delete()?; | ||
res | ||
fn run_wasmtime_test_with_spec(wasmbytes: &[u8]) -> Result<u32, Error> { | ||
let (exit_code, _, _) = WasiTest::<WasmtimeTestInstance>::builder()? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note that this test framework doesn't test starting containers in with containerd. One of the things we are interested in is the entire startup time including interactions with containerd and should make sure we have a test that covers that via a follow up
Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
@jsturtevant It turns out that wasmedge benchmarking wasn't working - it times out after 10 seconds. I need more time to investigate the WasmEdge case, so for this PR, I removed it. |
benches/containerd-shim-benchmarks/benches/webassembly-benchmarks.rs
Outdated
Show resolved
Hide resolved
benches/containerd-shim-benchmarks/benches/webassembly-benchmarks.rs
Outdated
Show resolved
Hide resolved
Signed-off-by: jiaxiao zhou <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Going to merge this in. Will work on the follow ups. |
This commit reverts back a change made by commit SHA 6882dd5 and fixed all the build errors for the benchmark.
cargo bench
to GitHub ActionsCloses #611