Add crate for stress testing the shims #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would unblock #615 |
2 tasks
Mossaka
reviewed
Nov 18, 2024
Signed-off-by: Jorge Prendes <[email protected]>
Signed-off-by: Jorge Prendes <[email protected]>
Signed-off-by: Jorge Prendes <[email protected]>
Signed-off-by: Jorge Prendes <[email protected]>
Signed-off-by: Jorge Prendes <[email protected]>
Signed-off-by: Jorge Prendes <[email protected]>
Signed-off-by: Jorge Prendes <[email protected]>
Signed-off-by: Jorge Prendes <[email protected]>
Signed-off-by: Jorge Prendes <[email protected]>
jprendes
force-pushed
the
stress-test
branch
from
643c578 to
80b360a
Compare
Mossaka
reviewed
Nov 20, 2024
Signed-off-by: Jorge Prendes <[email protected]>
|
Thanks for the feedback @Mossaka , updated :-) |
Mossaka
approved these changes
Nov 21, 2024
jsturtevant
reviewed
Nov 21, 2024
There was a problem hiding this comment.
sorry for the last review, was head down on a few different this this week and had some power outages.
Is there a reason we are coping in the protos and generating them when we already have a dep on rust-extensions which has these protos build for us?
https://github.com/containerd/rust-extensions/blob/main/crates/shim-protos/src/events.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the work presented during the last community meeting for stress testing the shims.
I intentionally left out running this in CI, as this is already a good amount of code.
We can add stress testing to CI on a different PR.