-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add doc for deploy with systemd #307
Conversation
62a915c
to
f10d13c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for PR!
Also, please squash the commits and sign it with your real name. |
c030138
to
f076c7d
Compare
ac77830
to
bc39212
Compare
docs/deploy.md
Outdated
``` | ||
tar -xvf stargz-snapshotter-${version}-linux-${arch}.tar.gz -C /usr/local/bin | ||
wget -O /etc/systemd/system/stargz-snapshotter.service https://raw.githubusercontent.com/containerd/stargz-snapshotter/master/script/config/etc/systemd/system/stargz-snapshotter.service | ||
systemctl enable stargz-snapshotter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
systemctl enable --now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refact to `systemctl enable --now
`
docs/deploy.md
Outdated
|
||
###### centos | ||
``` | ||
yum install fuse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dnf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added dnf script
docs/deploy.md
Outdated
@@ -0,0 +1,47 @@ | |||
# Deploy Stargz Snapshotter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file name should be INSTALL.md
, and should be linked from README.md: https://github.com/containerd/stargz-snapshotter#quick-start-with-kubernetes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put kubernetes section into INSTALL.md too, add link in README.md
@chenk008 Thanks for fixing the doc. Please fix whitespace errors reported by CI, squash the commits and sign the commit. |
f6fc87b
to
bb0c657
Compare
@ktock I have fixed these errors. Please take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@chenk008 Please fix whitespace errors reported by
|
719525f
to
1041d4c
Compare
1041d4c
to
7fd52b6
Compare
Signed-off-by: chenkang <[email protected]>
7fd52b6
to
b8f3b58
Compare
There is systemd service config, but lacks of deployment document.
I suggest that we can write a document to describe how to deploy stargz-snapshotter on different platforms such as Systemd, Kubernetes, AWS