fix: tests

containeroo · Aug 7, 2023 · 5a77325 · 5a77325
1 parent 898df90
commit 5a77325
Show file tree

Hide file tree

Showing 7 changed files with 22 additions and 9 deletions.
diff --git a/hack/p12.sh b/hack/p12.sh
@@ -35,6 +35,11 @@ done
 # create broken p12 file
 echo "broken" > broken.p12
 
+# create file with invalid extension
+echo "invalid" > cert.invalid
+
+# create file with no extension
+echo "no extension" > no_extension
 
 # create p12 file with a certificate chain
 cat final.crt intermediate.crt root.crt > chain.crt

diff --git a/hack/pem.sh b/hack/pem.sh
@@ -34,6 +34,12 @@ done
 # create broken pem file
 echo "broken" > broken.pem
 
+# create file with invalid extension
+echo "invalid" > cert.invalid
+
+# create file with no extension
+echo "no extension" > no_extension
+
 # create pem file with a certificate chain
 cat final.crt intermediate.crt root.crt > chain.crt
 # create pem file with a certificate chain and private key

diff --git a/internal/config/parse_test.go b/internal/config/parse_test.go
@@ -60,7 +60,7 @@ func TestParseConfig(t *testing.T) {
 				Certs: []certificates.Certificate{
 					{
 						Name:     "test_cert",
-						Path:     "path/to/cert.pem",
+						Path:     "../../tests/certs/pem/chain.pem",
 						Type:     "pem",
 						Password: fmt.Sprintf("file:%s", passwordFileName),
 						Enabled:  &trueVar,
@@ -101,7 +101,7 @@ func TestParseConfig(t *testing.T) {
 					{
 						Name:     "test_cert",
 						Enabled:  &trueVar,
-						Path:     "path/to/cert.pem",
+						Path:     "../../tests/certs/p12/root.p12",
 						Type:     "pem",
 						Password: "file:INVALID_FILE",
 					},
@@ -115,8 +115,7 @@ func TestParseConfig(t *testing.T) {
 				Certs: []certificates.Certificate{
 					{
 						Enabled: &trueVar,
-						Path:    "path/to/cert-with_special chars.pem",
-						Name:    "cert-with-special-chars-pem",
+						Path:    "../../tests/certs/pem/final.pem",
 					},
 				},
 			},
@@ -143,7 +142,7 @@ func TestParseConfig(t *testing.T) {
 					{
 						Name:    "test_cert",
 						Enabled: &trueVar,
-						Path:    "path/to/cert",
+						Path:    "../../tests/certs/p12/no_extension",
 					},
 				},
 			},
@@ -156,7 +155,7 @@ func TestParseConfig(t *testing.T) {
 					{
 						Name:    "test_cert",
 						Enabled: &trueVar,
-						Path:    "path/to/cert.invalid",
+						Path:    "../../tests/certs/pem/without_password.pem",
 						Type:    "invalid",
 					},
 				},
@@ -170,7 +169,7 @@ func TestParseConfig(t *testing.T) {
 					{
 						Name:    "test_cert",
 						Enabled: &trueVar,
-						Path:    "path/to/cert.invalid",
+						Path:    "../../tests/certs/pem/cert.invalid",
 					},
 				},
 			},
@@ -183,7 +182,7 @@ func TestParseConfig(t *testing.T) {
 					{
 						Name:    "test_cert",
 						Enabled: &trueVar,
-						Path:    "path/to/cert.p12",
+						Path:    "../../tests/certs/p12/chain.p12",
 					},
 				},
 			},
@@ -195,7 +194,6 @@ func TestParseConfig(t *testing.T) {
 		t.Run(testCase.name, func(t *testing.T) {
 			setEnvVars(envs)
 
-			fmt.Println("test name:", testCase.name)
 			err := ParseConfig(testCase.config)
 
 			unsetEnvVars(envs)

diff --git a/tests/certs/p12/cert.invalid b/tests/certs/p12/cert.invalid
@@ -0,0 +1 @@
+invalid
diff --git a/tests/certs/p12/no_extension b/tests/certs/p12/no_extension
@@ -0,0 +1 @@
+no extension
diff --git a/tests/certs/pem/cert.invalid b/tests/certs/pem/cert.invalid
@@ -0,0 +1 @@
+invalid
diff --git a/tests/certs/pem/no_extension b/tests/certs/pem/no_extension
@@ -0,0 +1 @@
+no extension