Skip to content

Conversation

@TomSweeneyRedHat
Copy link
Member

Bump runc to v1.2.8 to fix CVE-2025-52881. This also
fixes CVE-2025-31133 and CVE-2025-52566.

Partially fixes: https://issues.redhat.com/browse/OCPBUGS-64913, https://issues.redhat.com/browse/OCPBUGS-64911
once merged into Podman.

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@TomSweeneyRedHat TomSweeneyRedHat added the No New Tests Allow PR to proceed without adding regression tests label Nov 25, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TomSweeneyRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TomSweeneyRedHat TomSweeneyRedHat force-pushed the dev/tsweeney/cve-2025-52881-release-1.37 branch 3 times, most recently from 575e857 to eef214b Compare November 26, 2025 22:50
@packit-as-a-service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

Bump runc to v1.2.9 to fix CVE-2025-52881.  This also
fixes CVE-2025-31133 and CVE-2025-52565.

Partially fixes: https://issues.redhat.com/browse/OCPBUGS-64913, https://issues.redhat.com/browse/OCPBUGS-64911
once merged into Podman.

runc v1.2.9 also fixes a couple of regressions that were in
the original CVE 1.2.8 patch.

Signed-off-by: tomsweeneyredhat <[email protected]>
@TomSweeneyRedHat TomSweeneyRedHat force-pushed the dev/tsweeney/cve-2025-52881-release-1.37 branch from eef214b to ad2e3c9 Compare November 28, 2025 20:57
The latest runc requires Go 1.22.  Bump int in the Makefile to that
version.

Signed-off-by: tomsweeneyredhat <[email protected]>
These functions were removed in github.com/opencontainers/selinux
v1.12.0.

Signed-off-by: tomsweeneyredhat <[email protected]>
@TomSweeneyRedHat TomSweeneyRedHat force-pushed the dev/tsweeney/cve-2025-52881-release-1.37 branch 2 times, most recently from ad9979b to 7d4c4f7 Compare December 3, 2025 15:22
Bumping golang.org/x/tools to v0.26.0 per @nalind's
suggestion.

Signed-off-by: tomsweeneyredhat <[email protected]>
@TomSweeneyRedHat TomSweeneyRedHat force-pushed the dev/tsweeney/cve-2025-52881-release-1.37 branch from 7d4c4f7 to 0517f18 Compare December 3, 2025 16:08
TomSweeneyRedHat and others added 2 commits December 3, 2025 20:20
Apparently, per lint, the userns.RunningInUserNS() function
has moved from runc, to moby.  Update the library location.

Signed-off-by: tomsweeneyredhat <[email protected]>
Update references to specific versions of golang in the Makefile and the
Cirrus CI configuration to match go.mod, and add a check in the 'vendor'
target that CI runs that the image it's run inside is a close-enough
match to the version listed in go.mod.

Signed-off-by: Nalin Dahyabhai <[email protected]>
@TomSweeneyRedHat TomSweeneyRedHat force-pushed the dev/tsweeney/cve-2025-52881-release-1.37 branch from 0517f18 to c840a16 Compare December 4, 2025 01:21
Stealing from @cevich's work in containers#6520.
In CI, the project and tests are compiled, so therefore require newer
CI/VM images with support for the newer golang requirements.

Signed-off-by: tomsweeneyredhat <[email protected]>
@TomSweeneyRedHat TomSweeneyRedHat force-pushed the dev/tsweeney/cve-2025-52881-release-1.37 branch from c840a16 to 0fbbd55 Compare December 4, 2025 14:30
@nalind nalind force-pushed the dev/tsweeney/cve-2025-52881-release-1.37 branch from 02007e0 to 05e00fb Compare December 4, 2025 17:54
@TomSweeneyRedHat TomSweeneyRedHat force-pushed the dev/tsweeney/cve-2025-52881-release-1.37 branch 3 times, most recently from a18b612 to 824b927 Compare December 5, 2025 01:05
TomSweeneyRedHat and others added 3 commits December 5, 2025 14:02
Bumping onsi/ginkgo to v2 and the x/tools to v0.26
in the test/tools directory

Signed-off-by: tomsweeneyredhat <[email protected]>
Signed-off-by: Nalin Dahyabhai <[email protected]>
Signed-off-by: tomsweeneyredhat <[email protected]>
Ambient capabilities can't be raised without inheritable ones, and since we
don't raise inheritable, we should not raise ambient either.

This went unnoticed because of a bug in syndtr/gocapability which is
only fixed in its fork (see the next commit).

Amends commit e7e55c9.

Signed-off-by: Kir Kolyshkin <[email protected]>
Signed-off-by: tomsweeneyredhat <[email protected]>
@TomSweeneyRedHat TomSweeneyRedHat force-pushed the dev/tsweeney/cve-2025-52881-release-1.37 branch from 824b927 to 499b430 Compare December 5, 2025 19:03
nalind and others added 2 commits December 5, 2025 15:44
 ... setting RLIMIT_NPROC wrong

The version of containers/common we're currently using on this branch included a
bug which was later fixed by containers/common#2199.
If we get an update on its v0.60 branch which includes that fix, we can
drop this patch from this branch, but until then, work around the part
that breaks our tests.

Signed-off-by: Nalin Dahyabhai <[email protected]>
Signed-off-by: tomsweeneyredhat <[email protected]>
Bump Buildah to v1.37.7

Signed-off-by: tomsweeneyredhat <[email protected]>
@TomSweeneyRedHat TomSweeneyRedHat force-pushed the dev/tsweeney/cve-2025-52881-release-1.37 branch from 499b430 to 0e28a01 Compare December 5, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved No New Tests Allow PR to proceed without adding regression tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants