Skip to content

Commit

Permalink
drop --tty on exec
Browse files Browse the repository at this point in the history
as gvisor doesn't use it, and runc/crun don't need it, as they'll only use it if
the process args aren't defined, which conmon always does

Signed-off-by: Peter Hunt <[email protected]>
  • Loading branch information
haircommander committed Jan 8, 2024
1 parent 2dcd736 commit 8c6e47f
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/runtime_args.c
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@ GPtrArray *configure_runtime_args(const char *const csname)
/* Set the exec arguments. */
if (opt_exec) {
add_argv(runtime_argv, "exec", "--pid-file", opt_container_pid_file, "--process", opt_exec_process_spec, "--detach", NULL);
if (opt_terminal)
add_argv(runtime_argv, "--tty", NULL);
} else {
char *command;
if (opt_restore_path)
Expand Down

0 comments on commit 8c6e47f

Please sign in to comment.