logging: remove unuseful fsync #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the file is going to be removed few lines later with rename():
```
/* Replace the previous file */
if (rename(k8s_log_path_tmp, k8s_log_path) < 0) {
pexit("Failed to rename log file");
}
```
so there is no point in the expensive sync call since the file is not
supposed to be persisted after a reboot.
Signed-off-by: Giuseppe Scrivano <[email protected]>
saschagrunert
approved these changes
Jul 4, 2024
|
@haircommander PTAL |
|
we did hit issues in the past removing an fsync but I think it was because of the other one before the container exits. this should be okay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the file is going to be removed few lines later with rename():
so there is no point in the expensive sync call since the file is not supposed to be persisted after a reboot.