.github: opendownstream-pr add matrix for podman repo
#360
Conversation
Extend opendownstream-PR to support `podman` repo as well along with `buildah`. Signed-off-by: flouthoc <[email protected]>
|
Did a similar test on my fork with commit flouthoc@dd28bd6 and PR flouthoc#3 |
There was a problem hiding this comment.
Note blocking this here but should wait a bit more to get more feedback if this is really useful.
Since I was on PTO has anyone here found these buildah PRs useful, have the reviewers looked at the result of the buildah CI?
Because if nobody is looking then there is not much point in doing this.
Also note that this will trigger machine tests on each of these podman PRs as this is will fall under vendor/ chnages there and thus all jobs run. That is of course useful for proper coverage but also slower, much more flaky and expensive compared the all the other testing.
| - repo_name: buildah | ||
| fork_repo: podmanbot/buildah | ||
| upstream_repo: containers/buildah | ||
| - repo_name: podman | ||
| fork_repo: podmanbot/podman | ||
| upstream_repo: containers/podman |
There was a problem hiding this comment.
Is there a benfit to define all three values, you could have also just written
podmanbot/${{ matrix.repo_name }}' and containers/${{ matrix.repo_name }}' in the places instead. Though I guess it is mostly a style choice and this here should be fine
Yes we can wait more to see how it is actually going and get feedback. |
|
It'd be great if, say, the the description the bot provided for its PRs included a pointer to documentation about it, where to provide feedback, and described what the expectations are for maintainers on the receiving end. |
That sounds good, let me create a PR for that. |
Extend opendownstream-PR to support
podmanrepo as well along withbuildah.