chore(security): try to fix snyk security issues #345
Merged
+11
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous update wasn't made automatically. Signed-off-by: Marc Nuri <[email protected]>
Even after the fix, Snyk seems to be reporting false positives. Signed-off-by: Marc Nuri <[email protected]>
|
If this is false positive, we can exclude that part in here https://github.com/openshift/openshift-mcp-server/blob/main/.snyk with a good justification. We don't need to fix everything. Thanks for looking this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local snyk execution is still reporting issues 😞, but these should be false positives.
I can't find a way to make snyk believe this is safe 😅.
If the issue is still reported downstream we'll have to suppress the issue.
/cc @ardaguclu