sysfs,cpuallocator: add support for hybrid core discovery, preferred allocation. #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klihub
force-pushed
the
devel/hybrid-core-support
branch
2 times, most recently
from
b541412
to
f2065e1
Compare
pfl
approved these changes
Mar 19, 2024
fmuyassarov
approved these changes
Mar 19, 2024
klihub
force-pushed
the
devel/hybrid-core-support
branch
from
f2065e1
to
8edb83b
Compare
|
@klihub can you please rebase this one ? |
Add support for hybrid core architectures by introducing core types. Add an interface for querying the available core types. Define core types for P- and E-cores and implement detection for those types. Signed-off-by: Krisztian Litkey <[email protected]>
klihub
force-pushed
the
devel/hybrid-core-support
branch
from
8edb83b
to
3766e65
Compare
@fmuyassarov Rebased on latest main. |
klihub
force-pushed
the
devel/hybrid-core-support
branch
2 times, most recently
from
2f0800b
to
45cfa38
Compare
klihub
force-pushed
the
devel/hybrid-core-support
branch
from
45cfa38
to
d62c217
Compare
Thanks for spotting it. Fixed. |
klihub
force-pushed
the
devel/hybrid-core-support
branch
from
d62c217
to
724d7d5
Compare
Allow overriding automatic core type detection using environment variables. Among other things, this can be used for e2e tests to emulate a hybrid architecture on non-hybrid hosts. Signed-off-by: Krisztian Litkey <[email protected]>
Update sample/test sysfs data to report multiple/hybrid core types. Signed-off-by: Krisztian Litkey <[email protected]>
klihub
force-pushed
the
devel/hybrid-core-support
branch
from
724d7d5
to
f7c01cc
Compare
askervin
reviewed
Mar 26, 2024
marquiz
reviewed
Mar 26, 2024
klihub
force-pushed
the
devel/hybrid-core-support
branch
from
f7c01cc
to
217eef9
Compare
klihub
force-pushed
the
devel/hybrid-core-support
branch
from
217eef9
to
967146e
Compare
Classify all cores reported as E-cores by sysfs as low priority cores without looking at their cpufreq range. When sorting CPU sets for low-prio allocations, prefer the tightest fitting set which can satisfy the request with low-prio CPUs. Signed-off-by: Krisztian Litkey <[email protected]>
When sorting CPU sets for high-prio allocations, prefer the tightest fitting set which can satisfy the request with high-prio or normal-prio CPUs. Signed-off-by: Krisztian Litkey <[email protected]>
When allocating idle packages, consider a package idle if all
online cores *with preferred priorities* for that allocation
are idle. Also, from the picked packages take cores with this
same restriction. In particular, on hybrid architectures with
multiple core types, this will exclude
- E-cores from allocations with Priority{Normal,High} preference
- P-cores from allocations with PriorityLow preference
Signed-off-by: Krisztian Litkey <[email protected]>
klihub
force-pushed
the
devel/hybrid-core-support
branch
from
967146e
to
fef72fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes: This PR is stacked on top of #294 and #206.
This patch series adds support for discovering CPU cores of various kinds on hybrid core architecture systems. It also updates the CPU allocator to make better allocation choices on such systems, both with and without explicitly provided allocation preferences.