e2e: switch default test distro to fedora/40-cloud-base. #375
+18
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@askervin @fmuyassarov @kad @pfl PTAL. |
pfl
approved these changes
Oct 4, 2024
We need python-{selinux,packaging} with distro=fedora/40-cloud-image.
Signed-off-by: Krisztian Litkey <[email protected]>
Signed-off-by: Krisztian Litkey <[email protected]>
klihub
force-pushed
the
devel/e2e/default-to-fedora-40-cloud-base
branch
from
ee5279c
to
ab25ea1
Compare
fmuyassarov
reviewed
Oct 5, 2024
Comment on lines
+146
to
+155
| pkg: | ||
| - iproute-tc | ||
| - grubby | ||
| state: present | ||
| update_cache: true | ||
| - name: Extra python3 rpm packages for ansible | ||
| ansible.builtin.dnf: | ||
| pkg: | ||
| - python3-libselinux | ||
| - python3-packaging |
There was a problem hiding this comment.
I would merge these two tasks into one and create a single list of requires packages.
There was a problem hiding this comment.
The 2nd one is conditional not necessary (and neither possible) on our older Fedora distros.
fmuyassarov
approved these changes
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fedora 37 is EOL. Switch default test distro to fedora 40 and use cloud base image.