Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: fix provisioning for Ubuntu cloud image. #377

Merged
merged 1 commit into from
Oct 5, 2024
Merged

e2e: fix provisioning for Ubuntu cloud image. #377

merged 1 commit into from
Oct 5, 2024

Conversation

klihub
Copy link
Collaborator

@klihub klihub commented Oct 4, 2024

Ubuntu cloud image does not need a DNS fixup.

@klihub
e2e: fix provisioning for Ubuntu cloud image.
557a05b 
Ubuntu cloud image does not need a DNS fixup.

Signed-off-by: Krisztian Litkey <[email protected]>
kad
kad approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@kad kad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with it, but probably some day we would need to fix those sed with internal ansible line replacement, it would be faster in overall script runtime.

@fmuyassarov
Copy link
Collaborator

I'm ok with it, but probably some day we would need to fix those sed with internal ansible line replacement, it would be faster in overall script runtime.

+1

@fmuyassarov fmuyassarov merged commit e20ea5a into containers:main Oct 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kad kad kad approved these changes

@fmuyassarov fmuyassarov fmuyassarov approved these changes

@askervin askervin Awaiting requested review from askervin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@klihub @fmuyassarov @kad