Skip to content

Conversation

serbangeorge-m
Copy link
Contributor

@serbangeorge-m serbangeorge-m commented Sep 19, 2025

What does this PR do?

Screenshot / video of UI

What issues does this PR fix or reference?

Closes #3506

How to test this PR?

Signed-off-by: serbangeorge-m <[email protected]>
Signed-off-by: serbangeorge-m <[email protected]>
Signed-off-by: serbangeorge-m <[email protected]>
Copy link
Collaborator

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Wondering why the function has been moved, seeing a console.log in the test, maybe removed

Not sure to understand why we are skipping on Windows ?

@serbangeorge-m
Copy link
Contributor Author

@jeffmaury The PR check was failing with System.IO.IOException: No space left on device. I moved the test to the end of the spec to see if the error could still be reproduced. On Windows, the test is currently skipped because it fails when run through the pde2e-runner image. I’ve created a separate issue to track this podman-desktop/e2e#464

@serbangeorge-m serbangeorge-m merged commit 6f86503 into containers:main Sep 22, 2025
7 checks passed
@ScrewTSW
Copy link
Member

@jeffmaury The PR check was failing with System.IO.IOException: No space left on device. I moved the test to the end of the spec to see if the error could still be reproduced. On Windows, the test is currently skipped because it fails when run through the pde2e-runner image. I’ve created a separate issue to track this podman-desktop/e2e#464

You've moved it outside of the serial execution. The test now runs parallel, doesn't even necessarily wait for the extension to be installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix/Improve llama stack creation test
4 participants