-
Notifications
You must be signed in to change notification settings - Fork 65
chore(test): enable llama stack test #3599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: serbangeorge-m <[email protected]>
Signed-off-by: serbangeorge-m <[email protected]>
736963f
to
f686dd1
Compare
Signed-off-by: serbangeorge-m <[email protected]>
Signed-off-by: serbangeorge-m <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Wondering why the function has been moved, seeing a console.log in the test, maybe removed
Not sure to understand why we are skipping on Windows ?
@jeffmaury The PR check was failing with |
Signed-off-by: serbangeorge-m <[email protected]>
You've moved it outside of the serial execution. The test now runs parallel, doesn't even necessarily wait for the extension to be installed. |
What does this PR do?
Screenshot / video of UI
What issues does this PR fix or reference?
Closes #3506
How to test this PR?