fix: podman.domain.containers.run pulls image if not found #600
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tollsimy The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Simone Tollardo <[email protected]>
There was a problem hiding this comment.
Thanks for the contribution @tollsimy , I think it's a good PR, but I'd consider using the same logic that podman cli uses for this call. see my comment at the code
but maybe you thought about it, so I would like to hear your opinion on the matter.
depending on this, tests will need to be adjusted accordingly :)
| if response.status_code == requests.codes.not_found: | ||
| self.podman_client.images.pull( | ||
| image, | ||
| auth_config=kwargs.get("auth_config"), | ||
| platform=kwargs.get("platform"), | ||
| policy=kwargs.get("policy", "missing"), | ||
| ) | ||
| response = self.client.post( | ||
| "/containers/create", | ||
| headers={"content-type": "application/json"}, | ||
| data=payload, | ||
| ) |
There was a problem hiding this comment.
I was curious to see what podman cli does when you call create, so I tried. when you do podman-remote create you get a pull call no matter if the image is cached or not
POST /v5.7.0/libpod/images/pull
POST /v5.7.0/libpod/containers/create
therefore I would simply remove the if and try to pull every time you create
3 participants
Fixes: