-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Artifact add optimization on macOS and Windows #27426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Honny1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0b018d8 to
28a90c6
Compare
|
Quick breeze, it LGTM, and happy green test buttons to boot! |
|
really quick pass LGTM ... hopefully someone can walk through a little slower than today allowed. |
28a90c6 to
7a6d65e
Compare
|
Based on benchmark results, I disabled this improvement for WSL. I rebenchmarked this improvement on Windows 11 and it didn't get better, but overall CPU usage is lower. Let me know if you think disabling this feature for WSL makes sense. PTAL: @Luap99 @baude @TomSweeneyRedHat @mheon |
|
Unrelated CI failure; fixed in #27562 |
Fixes: https://issues.redhat.com/browse/RUN-3385 Fixes: containers#26321 Signed-off-by: Jan Rodák <[email protected]>
Signed-off-by: Jan Rodák <[email protected]>
The local API path optimization is ineffective on WSL because of NTFS mounting overhead. Signed-off-by: Jan Rodák <[email protected]>
7a6d65e to
d889aeb
Compare
|
LGTM |
|
PTAL @l0rd |
|
@Honny1 I have tested with hyper-v but I cannot see any difference in terms of perfs. I will look at it closer tomorrow. |
This PR adds a new local artifact add API endpoint and enforces absolute path requirements for local file operations.
Fixes: https://issues.redhat.com/browse/RUN-3385
Fixes: #26321
Benchmark
podman artifact add quay.io/myartifact/benchmark:latest ./artifacts/random-fileBenchmark Results:
Mac OS
Providers
applehv
libkrun (krunkit 0.2.1)
Windows
Providers
WSL
Hyper-V
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?