pkg/specgen/generate: Fix adding host devices on FreeBSD

[dfr]

This was not working when emulating Linux container images on FreeBSD. The code to handle host devices on FreeBSD relies on the container having a devfs mount. Unfortunately, the Linux emulation code which adds this was happening after the host device handling. This changes the logic so that host device management happens after Linux emulation.

Does this PR introduce a user-facing change?

Fix adding host devices to emulated Linux containers on FreeBSD.

[lsm5]

LGTM

[baude]

the code lgtm, but i wonder if it would be prudent to add a test of any kind to prevent regressions in the future?

[mheon]

/approve
LGTM for reference. If we decide this doesn't need tests, it's mergable now.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dfr, lsm5, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lsm5,mheon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[baude]

Ill override and restart tests for now. If we decide that it should have them, we can remove the label.

[dfr]

Ill override and restart tests for now. If we decide that it should have them, we can remove the label.

The best test for this would be a FreeBSD-only system test. I do have many of the Podman system tests working on the platform but enabling them for CI in some form was put on hold partly due to the lack of FreeBSD official base images (#19788). We now have official images (https://github.com/orgs/freebsd/packages, https://hub.docker.com/u/freebsd) so perhaps we can revisit that idea.

[baude]

LGTM then