-
Notifications
You must be signed in to change notification settings - Fork 2.9k
podman-systemd.unit.5: document /sbin/nologin accounts #27558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
podman-systemd.unit.5: document /sbin/nologin accounts #27558
Conversation
|
@hadmut Does it look okay? |
|
@eriksjolund I've rerun the tests that look too unhappy for the changes in this particular PR |
Honny1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, once @TomSweeneyRedHat's comments have been addressed.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eriksjolund, Honny1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dfd191a to
5b9fdda
Compare
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
|
/packit retest-failed |
|
Are the failed tests related to this PR? |
I dont think so, but to be sure, you are freshly rebased? |
Add command: sudo systemctl --machine username@ --user list-unit-files Fixes: containers#27544 Co-authored-by: Tom Sweeney <[email protected]> Signed-off-by: Erik Sjölund <[email protected]>
5b9fdda to
7741e04
Compare
I now rebased. Let's see if things change. |
|
Good tip, didn't know this one. |
Add command:
sudo systemctl --machine username@ --user list-unit-files
Fixes: #27544
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?