Skip to content

Conversation

@eriksjolund
Copy link
Contributor

Add command:
sudo systemctl --machine username@ --user list-unit-files

Fixes: #27544

Checklist

Ensure you have completed the following checklist for your pull request to be reviewed:

  • Certify you wrote the patch or otherwise have the right to pass it on as an open-source patch by signing all
    commits. (git commit -s). (If needed, use git commit -s --amend). The author email must match
    the sign-off email address. See CONTRIBUTING.md
    for more information.
  • Referenced issues using Fixes: #00000 in commit message (if applicable)
  • Tests have been added/updated (or no tests are needed)
  • Documentation has been updated (or no documentation changes are needed)
  • All commits pass make validatepr (format/lint checks)
  • Release note entered in the section below (or None if no user-facing changes)

Does this PR introduce a user-facing change?

None

@eriksjolund
Copy link
Contributor Author

@hadmut Does it look okay?

@TomSweeneyRedHat
Copy link
Member

@eriksjolund I've rerun the tests that look too unhappy for the changes in this particular PR

Copy link
Member

@Honny1 Honny1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once @TomSweeneyRedHat's comments have been addressed.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eriksjolund, Honny1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2025
@eriksjolund eriksjolund force-pushed the systemctl-for-nologin-accounts branch from dfd191a to 5b9fdda Compare November 19, 2025 17:42
@packit-as-a-service
Copy link

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

@Honny1
Copy link
Member

Honny1 commented Nov 20, 2025

/packit retest-failed

@eriksjolund
Copy link
Contributor Author

Are the failed tests related to this PR?
(I'm a little confused)

@baude
Copy link
Member

baude commented Nov 20, 2025

Are the failed tests related to this PR? (I'm a little confused)

I dont think so, but to be sure, you are freshly rebased?

Add command:
sudo systemctl --machine username@ --user list-unit-files

Fixes: containers#27544

Co-authored-by: Tom Sweeney <[email protected]>
Signed-off-by: Erik Sjölund <[email protected]>
@eriksjolund eriksjolund force-pushed the systemctl-for-nologin-accounts branch from 5b9fdda to 7741e04 Compare November 20, 2025 20:01
@eriksjolund
Copy link
Contributor Author

I dont think so, but to be sure, you are freshly rebased?

I now rebased. Let's see if things change.

@mheon
Copy link
Member

mheon commented Nov 20, 2025

Good tip, didn't know this one.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit f1b80bf into containers:main Nov 20, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none

Projects

None yet

Development

Successfully merging this pull request may close these issues.

quadlet->systemd generator uses wrong cidfile for non-root users

5 participants