Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for --override-platform flag #2175

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rittneje
Copy link
Contributor

@rittneje rittneje commented Dec 6, 2023

Closes #2118.

Copy link
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

My immediate reaction is that I don’t know how I feel about the way platforms.Parse defaults values; compare #1987 (comment) . The trade-off is consistency with containerd, which is certainly somewhat valuable.

Either way, this and #1987 should probably end up with a consistent answer to this trade-off.

@rhatdan
Copy link
Member

rhatdan commented Dec 6, 2023

@nalind thoughts?

@nalind
Copy link
Member

nalind commented Dec 8, 2023

This doesn't break anything, and it gets us closer to not being in the business of figuring out for ourselves which "variant" value to use on ARM boxes, so I'm fine with it. If that means reworking #1987, or scrapping it entirely, I'm not going to be particularly upset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support override via platform specifier
4 participants