Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers/quota.Control: lock a mutex when called #1604

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

drivers/quota.Control: lock a mutex when called #1604

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion drivers/quota/projectquota.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ import (
"os"
"path"
"path/filepath"
"sync"
"syscall"
"unsafe"

Expand All @@ -80,6 +81,7 @@ type Quota struct {
// Control - Context to be used by storage driver (e.g. overlay)
// who wants to apply project quotas to container dirs
type Control struct {
sync.Mutex // Lock()ed during every call to an exported method
backingFsBlockDev string
nextProjectID uint32
quotas map[string]uint32
Expand Down Expand Up @@ -191,7 +193,8 @@ func NewControl(basePath string) (*Control, error) {
// SetQuota - assign a unique project id to directory and set the quota limits
// for that project id
func (q *Control) SetQuota(targetPath string, quota Quota) error {

q.Lock()
defer q.Unlock()
projectID, ok := q.quotas[targetPath]
if !ok {
projectID = q.nextProjectID
Expand All @@ -218,6 +221,8 @@ func (q *Control) SetQuota(targetPath string, quota Quota) error {
// ClearQuota removes the map entry in the quotas map for targetPath.
// It does so to prevent the map leaking entries as directories are deleted.
func (q *Control) ClearQuota(targetPath string) {
q.Lock()
defer q.Unlock()
delete(q.quotas, targetPath)
}

Expand Down Expand Up @@ -275,6 +280,8 @@ func (q *Control) setProjectQuota(projectID uint32, quota Quota) error {

// GetQuota - get the quota limits of a directory that was configured with SetQuota
func (q *Control) GetQuota(targetPath string, quota *Quota) error {
q.Lock()
defer q.Unlock()
d, err := q.fsDiskQuotaFromPath(targetPath)
if err != nil {
return err
Expand All @@ -286,6 +293,8 @@ func (q *Control) GetQuota(targetPath string, quota *Quota) error {

// GetDiskUsage - get the current disk usage of a directory that was configured with SetQuota
func (q *Control) GetDiskUsage(targetPath string, usage *directory.DiskUsage) error {
q.Lock()
defer q.Unlock()
d, err := q.fsDiskQuotaFromPath(targetPath)
if err != nil {
return err
Expand Down