[release-1.45] Backport ignore chown errors in additionalimagestore #1992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of removing the "merged" directory, replace it with a fresh empty directory so that we can assume "merged" is always present and there is no need to recreate it. Signed-off-by: Giuseppe Scrivano <[email protected]>
ignore errors creating and chowning the diffDiff if it is in an additional image store. Signed-off-by: Giuseppe Scrivano <[email protected]> Signed-off-by: tomsweeneyredhat <[email protected]>
follow-up for ccb70a7 more information here: containers#1827 (comment) Addresses: https://issues.redhat.com/browse/ACCELFIX-244 Signed-off-by: Giuseppe Scrivano <[email protected]> Signed-off-by: tomsweeneyredhat <[email protected]>
TomSweeneyRedHat
force-pushed
the
dev/tsweeney/acel244-1.45
branch
from
1935ff8
to
b3ddeb7
Compare
Bump lint in the test area to 1.55.2 and then address an append that's causing lint heartache. Also change the install process for lint to be like the latest releases. Signed-off-by: tomsweeneyredhat <[email protected]>
TomSweeneyRedHat
force-pushed
the
dev/tsweeney/acel244-1.45
branch
from
b3ddeb7
to
7e892f1
Compare
|
Lint is failing here trying to get to to Debian: I thought at first that it was due to the changes I made to the lint install in tests/Makefile, but I reverted that and the same error. @cevich or @lsm5 are you aware of issues in this arena? |
I would just disable lint. This code is too old. |
|
Agree, disable lint. |
In containers#1992 there were a number of lint issues that were not solvable. After consulting with @edsantiago and @rhatdan, it was decided to remove the line processing from this branch. Signed-off-by: tomsweeneyredhat <[email protected]>
Signed-off-by: tomsweeneyredhat <[email protected]>
TomSweeneyRedHat
force-pushed
the
dev/tsweeney/acel244-1.45
branch
from
7e892f1
to
6aedf42
Compare
|
LGTM |
|
/approve |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rhatdan, TomSweeneyRedHat The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
TomSweeneyRedHat
added a commit
to TomSweeneyRedHat/storage
that referenced
this pull request
Jul 12, 2024
As the title says. In the last bump of c/storage in this branch, it was 1.45.7-dev and I should have bumped to 1.45.7, instead I skipped 7 and went to 1.45.8. See containers#1992 This corrects that. Signed-off-by: tomsweeneyredhat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports parts of #1828 and also #1784 to address:
https://issues.redhat.com/browse/ACCELFIX-244