Skip to content

Test CI, do not merge#1790

Closed
TristanCacqueray wants to merge 1 commit intocontainers:mainfrom
TristanCacqueray:test-ci
Closed

Test CI, do not merge#1790
TristanCacqueray wants to merge 1 commit intocontainers:mainfrom
TristanCacqueray:test-ci

Conversation

@TristanCacqueray
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the README.md file by adding a 'DNM' marker to the header image line. A review comment suggests using a Markdown comment for this marker instead of plain text to ensure it remains hidden in the rendered documentation.

Comment thread README.md
@@ -1,4 +1,4 @@
![README](data/gfx/README.gif)
![README](data/gfx/README.gif) DNM
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Appending 'DNM' as plain text to the README will cause it to be visible in the rendered documentation. For a change intended only to test CI, it is better to use a Markdown comment (e.g., <!-- DNM -->) to avoid affecting the user-facing content.

Suggested change
![README](data/gfx/README.gif) DNM
![README](data/gfx/README.gif) <!-- DNM -->

@centosinfra-prod-github-app
Copy link
Copy Markdown

Build failed.
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/local/buildset/7884fd4e32bd4dd186cd26ee98ff5e73

unit-test NODE_FAILURE Node(set) request 200-0000082631 failed in 0s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 15s
unit-test-restricted NODE_FAILURE Node(set) request 200-0000082633 failed in 0s
system-test-fedora-rawhide-commands-options NODE_FAILURE Node(set) request 200-0000082634 failed in 0s
system-test-fedora-rawhide-runtime-environment-arch-fedora NODE_FAILURE Node(set) request 200-0000082635 failed in 0s
system-test-fedora-rawhide-runtime-environment-ubuntu NODE_FAILURE Node(set) request 200-0000082636 failed in 0s
✔️ system-test-fedora-43-commands-options SUCCESS in 31m 15s
✔️ system-test-fedora-43-runtime-environment-arch-fedora SUCCESS in 22m 05s
✔️ system-test-fedora-43-runtime-environment-ubuntu SUCCESS in 6m 12s
✔️ system-test-fedora-42-commands-options SUCCESS in 31m 41s
✔️ system-test-fedora-42-runtime-environment-arch-fedora SUCCESS in 22m 39s
✔️ system-test-fedora-42-runtime-environment-ubuntu SUCCESS in 6m 10s

@TristanCacqueray
Copy link
Copy Markdown
Contributor Author

recheck

@TristanCacqueray
Copy link
Copy Markdown
Contributor Author

All good.

@debarshiray
Copy link
Copy Markdown
Member

Thanks @TristanCacqueray !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants