-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(telegram): add support for message_thread_id #362
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #362 +/- ##
==========================================
+ Coverage 78.92% 78.95% +0.03%
==========================================
Files 101 101
Lines 4431 4438 +7
==========================================
+ Hits 3497 3504 +7
Misses 756 756
Partials 178 178
☔ View full report in Codecov by Sentry. |
Looks good, but there are no tests. Also, how do you retrieve the thread ID? |
Test added, info on how to obtain the message_thread_id added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I'm not sure how I feel about linking a SO question in the docs, but perhaps it's better than nothing. We could always update the docs at a later time.
Is it okay to keep the |
Yeah, I think it's a good way to do it. Normally I would prefer to add another parameter, but since this is directly relating to a target it makes sense to use this. It also doesn't need to be escaped which is a plus! |
Documentation needs to be updated to reflect use and examples of Topic ID |
Reference: https://core.telegram.org/bots/api#sendmessage
closes #361