HMS-9620: use older method for finding content ids if they are null #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary:
Pulp added a new column on repo versions "Content_ids" which should make querying versions for content faster. They did not, however, update previous versions to include these ids, leaving that column null.
This change checks to see if any of the repo versions wanting to be searched have a null content_ids column. If so we use the old method for searching. If not we use the new method. This does take an extra small query to figure it out, but is much simpler than trying to do it all in a single query.
The code was also written in a way that hopefully will be easy to clean up after ~August 1st, 2026
To Test:
run:
You can also turn on debug logging to see the queries being run and confirm they are different.