Skip to content

fix: Use patched version of typed-path for zip #1761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scouten-adobe merged 2 commits into from
Jan 21, 2026
Merged

fix: Use patched version of typed-path for zip #1761

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81082ac
fix: Use patched version of typed-path for zip
cdmurph32 Jan 21, 2026
6c9e381
fix: Downgrade zip to 6 for WASI
cdmurph32 Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 34 additions & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion sdk/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,6 @@ uuid = { version = "1.18.0", features = ["serde", "v4"] }
web-time = "1.1"
x509-parser = "0.18.0"
zeroize = { version = "1.8", features = ["zeroize_derive"] }
zip = { version = "7.0.0", default-features = false }

# Use the asm feature of sha2 on aarch64 macOS for better performance. This nearly
# halves hashing time for large assets (> 50gb mp4, for example).
Expand Down Expand Up @@ -211,10 +210,13 @@ openssl = { version = "0.10.72", features = ["vendored"], optional = true }
ureq = { version = "3.1.0", default-features = false, features = [
"rustls"
], optional = true }
zip = { version = "7.0.0", default-features = false }

[target.'cfg(target_os = "wasi")'.dependencies]
wasi = { version = "0.14.3", optional = true }
wstd = { version = "0.5.4", optional = true }
# Use zip 6 for WASI to avoid typed-path wasip2 issue. Fix: http://github.com/chipsenkbeil/typed-path/pull/57
zip = { version = "6.0.0", default-features = false }

# `wstd` is required for testing, but optional as a normal dependency.
[target.'cfg(target_os = "wasi")'.dev-dependencies]
Expand Down Expand Up @@ -282,6 +284,7 @@ web-sys = { version = "0.3.58", features = [
"Window",
"WorkerGlobalScope",
] }
zip = { version = "7.0.0", default-features = false }

[dev-dependencies]
anyhow = "1.0.97"
Expand Down
Loading