-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade uuid to 1.7.0 & fix removed wasm-bindgen feature #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diliop
changed the title
Upgrade uuid to 1.7.0 to address & fix removed wasm-bindgen feature
Upgrade uuid to 1.7.0 & fix removed wasm-bindgen feature
Apr 23, 2024
gpeacock
approved these changes
May 1, 2024
Hi, thanks for submitting this. It is ready to go except for the Adobe CLA requirement. |
@gpeacock I signed the Adobe CLA a while back, let me know if there is anything else you need from me to merge this |
dkozma
approved these changes
Jun 7, 2024
facebook-github-bot
pushed a commit
to facebookincubator/reindeer
that referenced
this pull request
Jul 19, 2024
Summary: The git hash points to [#450](contentauth/c2pa-rs#450) which was posted upstream to accommodate the `pyo3` upgrade to `0.21.1` (D56671179). The PR was merged in [`c2pa = 0.32.7`](https://github.com/contentauth/c2pa-rs/releases/tag/v0.32.7). Reviewed By: dtolnay Differential Revision: D59975108 Privacy Context Container: L1122763 fbshipit-source-id: 75355f690075245065d0753ac526c17a0889932e
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Jul 19, 2024
Summary: The git hash points to [#450](contentauth/c2pa-rs#450) which was posted upstream to accommodate the `pyo3` upgrade to `0.21.1` (D56671179). The PR was merged in [`c2pa = 0.32.7`](https://github.com/contentauth/c2pa-rs/releases/tag/v0.32.7). Reviewed By: dtolnay Differential Revision: D59975108 Privacy Context Container: L1122763 fbshipit-source-id: 75355f690075245065d0753ac526c17a0889932e
facebook-github-bot
pushed a commit
to facebook/dotslash
that referenced
this pull request
Jul 19, 2024
Summary: The git hash points to [#450](contentauth/c2pa-rs#450) which was posted upstream to accommodate the `pyo3` upgrade to `0.21.1` (D56671179). The PR was merged in [`c2pa = 0.32.7`](https://github.com/contentauth/c2pa-rs/releases/tag/v0.32.7). Reviewed By: dtolnay Differential Revision: D59975108 Privacy Context Container: L1122763 fbshipit-source-id: 75355f690075245065d0753ac526c17a0889932e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Since
uuid
PR #536 thewasm-bindgen
feature has be renamed tojs
and since PR #727, thewasm-bindgen
dependency is optional and marked so usingdep:wasm-bindgen
under thejs
feature. With both these in place, given aCargo.toml
file that depends onuuid = "1.7.0"
:running
cargo build
will generate the following error:Upgrading
uuid
to1.70.0
and replacing thewasm-bindgen
feature withjs
insdk/Cargo.toml
fixes the above.Checklist
TO DO
items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.