Closest Preview: Add Sidebar UI [MAPS-58] #10145
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaquincasal
changed the title
FBanfi
approved these changes
Oct 3, 2025
Comment on lines
+12
to
22
| it('Renders entry list with titles and relative dates', async () => { | ||
| const { getAllByText } = render(<Sidebar />); | ||
|
|
||
| expect(getByText('Hello Sidebar Component (AppId: test-app)')).toBeInTheDocument(); | ||
| await waitFor(() => { | ||
| const entryTitles = getAllByText('Entry id', { exact: false }); | ||
| expect(entryTitles).toHaveLength(5); | ||
| }); | ||
|
|
||
| const updatedTexts = getAllByText(/Updated/); | ||
| expect(updatedTexts).toHaveLength(5); | ||
| }); |
There was a problem hiding this comment.
Nitpick: Perhaps I'll change the title of this test to 'Renders entry list with ids and relative dates', and when we change the logic to use the titles come back here and change it.
Because currently we are rendering a entry list with ids.
Same with the
const entryTitles = getAllByText('Entry id', { exact: false });
to
const entryIds = getAllByText('Entry id', { exact: false });
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add UI for the app sidebar.
Approach
This only includes how the sidebar looks, the behaviour of showing the correct link will be handled in a separate PR.
Testing steps
Automatic tests were added.
We display entries id for now, when we have to fetch the actual entries we'll use entry titles.