chore: 🤖 Yarn upgrade, tsdx and docz version bump #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanweDE
force-pushed
the
bump-tsdx
branch
3 times, most recently
from
ba64a80 to
39bce2b
Compare
DanweDE
changed the title
DanweDE
changed the title
suevalov
approved these changes
Jan 31, 2020
| @@ -31,7 +31,7 @@ export function MultipleLineEditor(props: MultipleLineEditorProps) { | |||
| error={errors.length > 0} | |||
| disabled={disabled} | |||
| value={value || ''} | |||
| onChange={(e: React.ChangeEvent<HTMLInputElement>) => { | |||
| onChange={(e: React.ChangeEvent<HTMLTextAreaElement>) => { | |||
package.json
Outdated
| @@ -77,7 +81,7 @@ | |||
| "remark-preset-lint-recommended": "^3.0.3", | |||
| "remark-validate-links": "^9.0.1", | |||
| "start-server-and-test": "^1.10.6", | |||
| "tsdx": "0.11.0", | |||
| "tsdx": "0.12.0", | |||
There was a problem hiding this comment.
there is 0.12.3 available already. do we need 0.12.0?
There was a problem hiding this comment.
Good point, I'll look into that.
| @@ -1,3 +1,4 @@ | |||
| import noop from 'lodash-es/noop'; | |||
There was a problem hiding this comment.
I'd import `import noop from 'lodash/noop' as we do in other places. TSDX transforms it to tree-shakable thing automatically
There was a problem hiding this comment.
I already tried that but I got
SyntaxError: Unexpected token 'export'
> 1 | import noop from 'lodash-es/noop';
| ^
2 | import React, { useState, useCallback } from 'react';
3 | import { css } from 'emotion';
4 | import tokens from '@contentful/forma-36-tokens';
While already spending too much time on all of this chore stuff I decided not to look into it. If you can point me at how to solve this without lots of trial and error let me know and I can do.
There was a problem hiding this comment.
I'd leave it as it is then :)
- To use .jsx files in the upcoming rich text field editor we need tsdx 0.12 together with the workaround mentioned on jaredpalmer/tsdx#443 - Use docz 1.3.2 - Ran `yarn upgrade`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To use .jsx files in the upcoming rich text field editor we need tsdx 0.12 together with the workaround mentioned on jaredpalmer/tsdx#443