Commenting out code for creating 2nd interface on VMs. Not needed. Ch… #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anging machine to t2.micro to save money.
neelimamukiri
approved these changes
Jul 19, 2017
|
Since this is only used by Jenkins, I don't see a point in having a "small" and "large" version. If you would like, I could make machine type an external variable that you specify in the aws.tfvars file or it could be specified on the command line when you do the terraform apply. Otherwise it's just one line inside the script to change the machine type that is used. |
|
@dojacobs, in that case why not just delete the commented lines? |
|
@rhim's thinking was that we might need them in the future. It's no big deal either way. What is the normal process? |
|
Updated file with the commented lines deleted. |
dseevr
approved these changes
Aug 4, 2017
|
@contiv/maintainers-deployment PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…anging machine to t2.micro to save money.