DO NOT MERGE: Fix iptables persistence after reboot #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, etcd iptables rule doesn't persist after reboot. This is because we have to enable the iptables service. Otherwise, iptables service will not load after reboot
tiewei
reviewed
Oct 11, 2017
| @@ -26,14 +27,20 @@ | |||
| yum: pkg={{ item }} state=present | |||
| with_items: | |||
| - iptables-services | |||
| when: ansible_distribution == 'CentOS' or ansible_distribution == 'Red Hat Enterprise Linux' | |||
| when: ansible_distribution == 'CentOS' or ansible_distribution == 'RedHat' | |||
There was a problem hiding this comment.
should be able to use ansible_os_family instead
tiewei
reviewed
Oct 11, 2017
roles/etcd/tasks/main.yml
Outdated
| @@ -1,3 +1,4 @@ | |||
| [metacloud@mcp1 ansible]$ cat roles/etcd/tasks/main.yml | |||
tiewei
reviewed
Oct 11, 2017
| apt: name={{item}} state=installed | ||
| with_items: | ||
| - iptables-persistent | ||
| when: ansible_distribution == 'Debian' or ansible_distribution == 'Ubuntu' | ||
|
|
||
| - name: Enable iptables service | ||
| command: systemctl enable iptables |
There was a problem hiding this comment.
use service module instead
tiewei
reviewed
Oct 11, 2017
| command: systemctl enable iptables | ||
|
|
||
| - name: Start iptables service | ||
| command: systemctl start iptables |
tiewei
reviewed
Oct 11, 2017
| @@ -45,10 +51,10 @@ | |||
| - "{{ etcd_peer_port1 }}" | |||
| - "{{ etcd_peer_port2 }}" | |||
|
|
|||
| # Save rules into /etc/sysconfig/iptables file for restoring rules on boot | |||
| # Save rules into /etc/sysconfig/iptables file for restoring rules on boot | |||
| - name: Save iptables | |||
| command: service iptables save | |||
There was a problem hiding this comment.
I think we should use systemctl instead ... , but this may still work on older version of rhel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, etcd iptables rule doesn't persist after reboot. This is
because we have to enable the iptables service. Otherwise, iptables
service will not load after reboot