Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not use sudo for local fetch ucp task #80

Merged
merged 1 commit into from
Feb 20, 2016
Merged

do not use sudo for local fetch ucp task #80

merged 1 commit into from
Feb 20, 2016

Conversation

vvb
Copy link
Contributor

@vvb vvb commented Feb 17, 2016

references: ansible/ansible#10906

@mapuri
Copy link
Contributor

mapuri commented Feb 17, 2016

LGTM

@mapuri
Copy link
Contributor

mapuri commented Feb 17, 2016

thinking more, may be we should add a task that checks/validates that the ansible control machine is running ansible v2.0. WDYT?

We can track that as a separate issue may be.

@vvb
Copy link
Contributor Author

vvb commented Feb 17, 2016

@mapuri yes, I will add the check.

@mapuri
Copy link
Contributor

mapuri commented Feb 20, 2016

@vvb, is this ready for merge?

Were you planning to add ansible version check as part of this? I have filed #87 to perform some checks, may be we can address it as part of that PR.

@vvb
Copy link
Contributor Author

vvb commented Feb 20, 2016

@mapuri that sounds better. so, this is good to merge then.

mapuri added a commit that referenced this pull request Feb 20, 2016
do not use sudo for local fetch ucp task
@mapuri mapuri merged commit b54480f into contiv:master Feb 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants