-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update service load balancer feature document #165
base: master
Are you sure you want to change the base?
Conversation
@@ -17,16 +17,95 @@ Services offer: | |||
- Minimal downtime. | |||
|
|||
A provider is one or more containers that match the label selector associated with the services. | |||
**Note**: This feature would be deprecated since docker 1.12 onword service load balancer feature is supported natively by docker swarm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
onword -> onward
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
that group providers with matching labels. | ||
|
||
To create a Service Load Balancer using the UI: | ||
###To create a Service Load Balancer using netctl: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A space is required after ###
so it shows up as a heading properly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
To create a Service Load Balancer using the UI: | ||
###To create a Service Load Balancer using netctl: | ||
|
||
1\. Create newtwork as net0-2 in tenant default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
newtwork -> network
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"tenant default" sounds weird... I'd change these three to say "default tenant"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, will change it
netctl service create svc-0-default --network svc-net-2-0 -t default --selector=key0=value1 --selector=key1=value2 --selector=key2=value3 --selector=key3=value4 --port=80:8080:TCP --port=643:7070:UDP | ||
|
||
|
||
After above operation, check service IPs , using _netctl service inspect <service name>_. In this example, service Ips is 30.2.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use a single backtick before and after the command to highlight it like this
Please remove the extraneous comma: "IPs , using" -> "IPs using"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using backtick will break format consistence in the document page.
|
||
After above operation, check service IPs , using _netctl service inspect <service name>_. In this example, service Ips is 30.2.0.1 | ||
|
||
```` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocks only use three backticks, not four
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok . rearrange format now.
docker exec -it net0-2-srv2-2-2 nc -z -n -v -w 1 30.2.0.1 80 | ||
docker exec -it net0-2-srv0-0-0 nc -z -n -v -w 1 30.2.0.1 80 | ||
|
||
8.\ As above operation result, client utiltiy must be connected to the service |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what this sentence is trying to say. What is the "client utility"? Why is there no text under this step?
"utiltiy" -> "utility"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think , you are right . this sentence shouldn't be exist. docker exec operation itself explain the outcome. removing the sentence now
|
||
|
||
|
||
###To create a Service Load Balancer using the UI: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a space after ###
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok.
Don't forget to run |
The changes look fine, but could you merge all these commits into one using |
Actually, I can just have these combined into one commit when I merge it lol @g1rana is this ready to go or are there more changes to be made? |
@g1rana do we still want to merge this? To resolve the conflict, just delete sitemap.xml on your branch, rebase against the latest changes on master, then re-run |
Add section to configure service load balancer using netctl