Use contributte/qa and fix build QA #125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dent does not exist This is handled differently in the PHPCSStandards/PHP_CodeSniffer 3.8.0, the property seems to be tabIndent, and always was maybe.
spaze
force-pushed
the
spaze/contributte-qa
branch
2 times, most recently
from
b24de9a
to
59575a2
Compare
Attempt to fix "Type mixed cannot be marked as nullable since mixed already includes null" on older PHPs
spaze
force-pushed
the
spaze/contributte-qa
branch
from
7a6cae8
to
e6ecbbc
Compare
But the alias is defined in the new class file but maybe instead of loading the file, a new alias map should be created? https://phpstan.org/user-guide/discovering-symbols#class-aliases
spaze
changed the title
|
closed by ae4ff4e |
|
@spaze promin, ale tento PR mi nejak unikl a vsiml jsem si ho az po vydani nove verze |
|
@aleswita V cajku, díky! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use contributte/qa instead of ninjify/qa in an attempt to fix
spaceIndentdoes not exist. This is handled differently in the PHPCSStandards/PHP_CodeSniffer 3.8.0, the property seems to be tabIndent, and always was maybe.The change required some style updates to the code base to adhere to the contributte standard.
StaticCallNodeis an alias ofStaticMethodCallNodein Latte 3.0.12 But the alias is defined in the new class file but maybe instead of loading the file, a new alias map should be created?