Skip to content

Commit

Permalink
Php8.3 (#314)
Browse files Browse the repository at this point in the history
* add PHP8.3 Support

* fix risk tests
  • Loading branch information
jleonardolemos authored Dec 5, 2023
1 parent e89312a commit 6596f3d
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/continous-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
runs-on: ubuntu-20.04
strategy:
matrix:
php-versions: ['8.1', '8.2']
php-versions: ['8.1', '8.2', '8.3']

steps:
- uses: actions/checkout@v2
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]
## [v2.3.0]
### Added
- Support PHP 8.3

## [v2.2.1]
### Removed
- Remove webpatser/uuid dependency.
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM php:8.2-fpm-alpine
FROM php:8.3-fpm-alpine

COPY --from=composer:latest /usr/bin/composer /usr/bin/composer
RUN apk --no-cache --update add libmemcached-dev zlib-dev libpng-dev libjpeg-turbo-dev freetype-dev libxml2-dev
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
}
],
"require": {
"php": ">=7.3|>=8.1",
"php": ">=7.3",
"ext-json": "*",
"ext-sockets": "*",
"php-amqplib/php-amqplib": "^3.1",
Expand Down
9 changes: 6 additions & 3 deletions tests/Unit/ResolverTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ public function test_it_should_ack_message()

//assert
$this->channel->shouldReceive('basic_ack')
->with($delivery_tag);
->with($delivery_tag)
->once();

// act
$resolver->ack();
Expand All @@ -56,7 +57,8 @@ public function test_it_should_reject_message_without_requeue()

//assert
$this->channel->shouldReceive('basic_nack')
->with($delivery_tag, false, $requeue);
->with($delivery_tag, false, $requeue)
->once();

// act
$resolver->reject($requeue);
Expand All @@ -75,7 +77,8 @@ public function test_it_should_reject_message_with_requeue()

//assert
$this->channel->shouldReceive('basic_nack')
->with($delivery_tag, false, $requeue);
->with($delivery_tag, false, $requeue)
->once();

// act
$resolver->reject($requeue);
Expand Down

0 comments on commit 6596f3d

Please sign in to comment.