Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incompatibility with Roundcube 1.3+ #3

Merged
merged 2 commits into from
Jan 28, 2018

Conversation

diditopher
Copy link
Contributor

@diditopher diditopher commented Jan 20, 2018

Fixes the following issue: When the plugin is used with Roundcube 1.3+, "Preferences" -> "User Interface" stops working. In logs/errors the following message appears:

[20-Jan-2018 09:42:20 Europe/Berlin] PHP Fatal error:  Uncaught Error: Call to undefined function Q() in /srv/www/roundcube/beta/plugins/converse/converse.php:272
Stack trace:
#0 /srv/www/roundcube/beta/program/lib/Roundcube/rcube_plugin_api.php(440): converse->preferences_list(Array)
#1 /srv/www/roundcube/beta/program/steps/settings/func.inc(1265): rcube_plugin_api->exec_hook('preferences_lis...', Array)
#2 /srv/www/roundcube/beta/program/steps/settings/edit_prefs.inc(28): rcmail_user_prefs('general')
#3 /srv/www/roundcube/beta/index.php(303): include_once('/srv/www/roundc...')
#4 {main}
  thrown in /srv/www/roundcube/beta/plugins/converse/converse.php on line 272

This fix should work in older versions, but I only tested with Roundcube 1.3.4

@diditopher
Copy link
Contributor Author

diditopher commented Jan 20, 2018

I also just updated composer.json to point to https://github.com/devurandom/roundcube-converse.js-xmpp-plugin instead of the unmaintained https://github.com/priyadi/roundcube-converse.js-xmpp-plugin. This should probably also be updated in the roundcube plugin repository

@devurandom
Copy link
Collaborator

LGTM

@devurandom devurandom merged commit 11fa2af into conversejs:master Jan 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants