Repository navigation
Merge the password provider back to the core - #389
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This was referenced Jul 9, 2026
Member
Author
Nicolapps
marked this pull request as ready for review
July 9, 2026 23:55
This was referenced Jul 10, 2026
Nicolapps
force-pushed
the
nicolas/merge-auth-password-package
branch
from
July 10, 2026 17:50
4fd094c to
baccaf1
Compare
Nicolapps
force-pushed
the
nicolas/auth-password-example
branch
from
July 10, 2026 17:50
a6783d2 to
63ccfc0
Compare
Nicolapps
force-pushed
the
nicolas/merge-auth-password-package
branch
2 times, most recently
from
July 10, 2026 18:19
1b4e4c1 to
1a1f2a4
Compare
Member
Author
Merge activity
|
Nicolapps
changed the base branch from
nicolas/auth-password-example
to
graphite-base/389
July 10, 2026 18:41
Nicolapps
force-pushed
the
nicolas/merge-auth-password-package
branch
from
July 10, 2026 18:44
1a1f2a4 to
ae4de63
Compare
Nicolapps
added a commit
that referenced
this pull request
Aug 12, 2026
I realized the username+password sign-up/sign-in flows are implemented with `actionGeneric` instead of `mutationGeneric`. This is my mistake, I implemented #389 with the wrong primitive and I didn’t catch it during code review. The current implementation was definitely wrong: without doing everything in a single transaction, it could have caused concurrency bugs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.