Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a devcontainer configuration with Docker #4198
Add a devcontainer configuration with Docker #4198
Changes from 18 commits
2b39cce
512e210
be723e8
bdb9be5
6cbc36b
486889d
ca75dda
0819f6e
a9edcf4
9f2b9f7
b7942bb
b181eb1
e8464b0
a5b14d7
5ddaad2
69f28f1
18bf5a4
b3a5060
2b46c5a
00cbee6
4373921
6c1be80
45ee32e
2f86c76
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain why we need this one? It seems a bit unrelated (I don't see prettier configured).
I'm asking because In the pre-commit config, we exclude Django templates from prettier in another way:
cookiecutter-django/{{cookiecutter.project_slug}}/.pre-commit-config.yaml
Line 25 in 2e561ed
Maybe we should make the 2 exclusins more consistent?