Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Drone CI #4382

Merged
merged 5 commits into from
Jul 28, 2023

Conversation

shywn-mrk
Copy link
Contributor

Description

Added Drone CI support and configuration.

Checklist:

  • I've added the option to choose Drone as the CI tool.
  • I've updated the documentation.
  • I've made sure that the config file is deleted when Drone is not selected.
  • I've added the Drone config file.

Rationale

Fix #2082

Copy link
Member

@browniebroke browniebroke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the contribution. Do you know of a convenient way for us, maintainers, to test this? No worries if not, though.

@shywn-mrk
Copy link
Contributor Author

@browniebroke You're welcome! At this moment, unfortunately, no. But still trying to understand a way to somehow figure it out.

@browniebroke
Copy link
Member

Are there any update on this? If not, I'm happy to accept it as community contributed as is. It's very much self-contained and easy to remove if we change our mind.

@shywn-mrk
Copy link
Contributor Author

@browniebroke Right now I don't have any updates, but at that moment I checked for some static analyzing tools to ensure that the outputted syntax is correct but didn't find much. If I find anything I'll definitely inform you and support any changes. If it's possible for you to merge, I'll be happy. And actually, this if my first open-source contribution. :)

@browniebroke browniebroke merged commit 40ddc4b into cookiecutter:master Jul 28, 2023
1 check passed
@browniebroke
Copy link
Member

Ok, let's get it out, we might get some feedback from people using it, and it shouldn't impact those who don't.

@browniebroke browniebroke changed the title Add support for drone.io (Fix #2082) Add support for Drone CI Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for drone.io
2 participants