Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only include prettier pre-commit hook with node-based front-end pipeline #4418

Merged
merged 3 commits into from
Jun 27, 2023
Merged

Only include prettier pre-commit hook with node-based front-end pipeline #4418

merged 3 commits into from
Jun 27, 2023

Conversation

Andrew-Chen-Wang
Copy link
Contributor

@Andrew-Chen-Wang Andrew-Chen-Wang commented Jun 26, 2023 •
edited by browniebroke
Loading

Description

Remove prettier webpack integration in pre-commit

Checklist:

  • I've made sure that tests are updated accordingly (especially if adding or updating a template option)
  • I've updated the documentation or confirm that my change doesn't require any updates

Rationale

I use nvm and PyCharm, so this pre-commit hook does not apply due to different IDE and because I'm not using node based frontend.

@browniebroke browniebroke merged commit d13e427 into cookiecutter:master Jun 27, 2023
11 checks passed
@browniebroke browniebroke changed the title Remove prettier webpack in pre-commit Only include prettier pre-commit hook with node-based front-end pipeline Jun 27, 2023
@browniebroke browniebroke mentioned this pull request Jul 10, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@browniebroke browniebroke browniebroke left review comments

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Andrew-Chen-Wang @browniebroke