Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keywords case warning in Dockerfile #5164

Merged

Conversation

browniebroke
Copy link
Member

@browniebroke browniebroke commented Jun 24, 2024

Description

Recently noticed the following warning in my Docker builds (using https://github.com/docker/build-push-action):

WARN: FromAsCasing: 'as' and 'FROM' keywords' casing do not match

I don't think it's causing any harm, apart perhaps some small noise in the logs... Seems like a good thing to do for consistency of keywords.

Checklist:

  • I've made sure that tests are updated accordingly (especially if adding or updating a template option)
  • I've updated the documentation or confirm that my change doesn't require any updates

Rationale

Recently noticed the following warning in my Docker builds:

> WARN: FromAsCasing: 'as' and 'FROM' keywords' casing do not match

I don't think it's causing any harm, apart perhaps some small noise in the logs.
Copy link
Collaborator

@luzfcb luzfcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luzfcb luzfcb merged commit 1f82072 into cookiecutter:master Jun 26, 2024
13 checks passed
@browniebroke browniebroke deleted the fix/docker-from-as-casing-warning branch June 26, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants