Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set allauth email subject prefix #5278

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

alexkanavos
Copy link
Contributor

Description

As I was working with cookiecutter django on a personal project I encountered an issue with one of the variables handling the email details.

  • I've made a small change in production.py file regarding the name of EMAIL_SUBJECT_PREFIX.
  • I've NOT updated the documentation, because I didn't want to mess up the srt file (new var name was a bit long).

You can read more on this stackoverflow answer.

@browniebroke
Copy link
Member

That will only work for accounts related email though? The current setting is for all emails sent by Django. Does Django-allauth has their own custom logic to send email? Seems a bit surprising that they wouldn't default to Django's setting.

@alexkanavos
Copy link
Contributor Author

In my project I used mailgun in production, but I tested with mailpit locally as well. I think is an allauth related variable and not a django one.

@browniebroke browniebroke changed the title Change email subject prefix variable name in settings Set allauth email subject prefix Sep 17, 2024
@browniebroke browniebroke merged commit 8431c36 into cookiecutter:master Sep 17, 2024
13 checks passed
@browniebroke
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants