-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Fix issue #3745: Use Django Browser Reload instead a Javascript based one for auto reload #6016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ionality Co-authored-by: MauGx3 <[email protected]>
…fully Co-authored-by: MauGx3 <[email protected]>
…-d23ca204e850 Replace browser-sync with django-browser-reload for auto-reload functionality
…n.py Co-authored-by: MauGx3 <[email protected]>
…-4720fa4d4ca5 Fix ResourceWarning for unclosed files in test suite
Added a fix for ResourceWarning in the test suite: MauGx3#3 |
Thanks for the contribution and the upfront disclosure of using an AI tool, much appreciated. Have you done a self-review and tested it before submitting? This might take some time for me to do, and I would appreciate if potential AI hallucinations/mistakes were caught earlier.
This is a bit of a separate fix, much easier to review and accept and would be happy to fast track it. Would you mind opening a separate PR for it? Thanks! |
…eneration.py" This reverts commit decfd22.
@browniebroke I've reviewed all files except for the gulpfile.mjs, because I don't know much about gulp, so I was hoping someone with more experience could review the file. I've asked Copilot to provide reasing for the changes in the original PR, so that could help as well. Other than that the files are package stuff and comments on the new feature for the documentation. I've tried running the command As for the tests issue I've created the pull request #6020. I definitely agree that further testing of this feature should be done before merging |
I've come across this issue, found it interesting and thought of having Copilot Agent give it a try. It generated this pull request and I've asked for it to comment on some changes that I've considered are more important.