Skip to content

Conversation

MauGx3
Copy link
Contributor

@MauGx3 MauGx3 commented Sep 7, 2025

I've come across this issue, found it interesting and thought of having Copilot Agent give it a try. It generated this pull request and I've asked for it to comment on some changes that I've considered are more important.

@MauGx3 MauGx3 marked this pull request as ready for review September 7, 2025 00:10
Copilot AI and others added 2 commits September 7, 2025 00:24
@MauGx3
Copy link
Contributor Author

MauGx3 commented Sep 7, 2025

Added a fix for ResourceWarning in the test suite: MauGx3#3

@browniebroke
Copy link
Member

Thanks for the contribution and the upfront disclosure of using an AI tool, much appreciated. Have you done a self-review and tested it before submitting? This might take some time for me to do, and I would appreciate if potential AI hallucinations/mistakes were caught earlier.

Added a fix for ResourceWarning in the test suite: MauGx3#3

This is a bit of a separate fix, much easier to review and accept and would be happy to fast track it. Would you mind opening a separate PR for it?

Thanks!

@MauGx3
Copy link
Contributor Author

MauGx3 commented Sep 7, 2025

@browniebroke I've reviewed all files except for the gulpfile.mjs, because I don't know much about gulp, so I was hoping someone with more experience could review the file. I've asked Copilot to provide reasing for the changes in the original PR, so that could help as well. Other than that the files are package stuff and comments on the new feature for the documentation.

I've tried running the command uvx cookiecutter https://github.com/maugx3/cookiecutter-django and the template loaded properly, but I didn't go through creating and testing an app yet

As for the tests issue I've created the pull request #6020. I definitely agree that further testing of this feature should be done before merging

@MauGx3 MauGx3 marked this pull request as draft September 13, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants