Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow the className prop for ReactPlayer #1842

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SEOKKAMONI
Copy link

@SEOKKAMONI SEOKKAMONI commented May 9, 2024

description

In some CSS libraries, there are cases where styles are inherited via the className. When disallowing such className, you may need to develop that specific part of the project using a different pattern than the one you previously used. Therefore, I added code to allow the className prop.

Example of Panda CSS

AS-IS

<div className={videoPlayerWrapperCss}>
   <ReactPlayer
        style={{ borderRadius: '16px', ... }}
        url={videoUrl}
        playing={true}
        controls={true}
        muted={true}
        width="100%"
        height="100%"
      />
</div>

TO-BE

<div className={videoPlayerWrapperCss}>
   <ReactPlayer
        className={css({ borderRadius: '16px', ... })}
        url={videoUrl}
        playing={true}
        controls={true}
        muted={true}
        width="100%"
        height="100%"
      />
</div>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant