Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version bump, and update URL for manuf file. #35

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

stavlor
Copy link

@stavlor stavlor commented Aug 10, 2023

Update URL for manuf data to new wireshark location and bump version info.

Copy link
Collaborator

@tristanlatr tristanlatr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot

@tristanlatr
Copy link
Collaborator

Argh, github runners are getting HTTP Error 429: Too Many Requests from the wireshark server :/

@stavlor
Copy link
Author

stavlor commented Aug 10, 2023

Lovely leave it to them to set low rate limits on things ;(

@joshschmelzle
Copy link

Should probably update the URL for the tests too.

MANUF_URL = "https://gitlab.com/wireshark/wireshark/raw/master/manuf"

@tristanlatr
Copy link
Collaborator

tristanlatr commented Aug 15, 2023

For the sake of passing the tests, I think we should use the local copy of the manuf file only. And update it eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants