Skip to content

Feature: Fallback Processors #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Feature: Fallback Processors #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3499c2
feat: impl ProcessFallback processor
Josscoder May 28, 2025
cbf6c25
feat: improve fallback processors
Josscoder May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 20 additions & 11 deletions session/processor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,12 @@ type Processor interface {
ProcessCache(ctx *Context, new *[]byte)
// ProcessDisconnection is called when the player disconnects from the proxy.
ProcessDisconnection(ctx *Context, message *string)
// ProcessPreFallback is called before transferring the player to a fallback server.
ProcessPreFallback(ctx *Context, origin *string, target *string)
// ProcessFallbackFailure is called when the fallback transfer fails.
ProcessFallbackFailure(ctx *Context, origin *string, target *string, err error)
// ProcessPostFallback is called after transferring the player to a fallback server.
ProcessPostFallback(ctx *Context, origin *string, target *string)
}

// NopProcessor is a no-operation implementation of the Processor interface.
Expand All @@ -57,14 +63,17 @@ type NopProcessor struct{}
// Ensure that NopProcessor satisfies the Processor interface.
var _ Processor = NopProcessor{}

func (NopProcessor) ProcessStartGame(_ *Context, _ *minecraft.GameData) {}
func (NopProcessor) ProcessServer(_ *Context, _ *packet.Packet) {}
func (NopProcessor) ProcessServerEncoded(_ *Context, _ *[]byte) {}
func (NopProcessor) ProcessClient(_ *Context, _ *packet.Packet) {}
func (NopProcessor) ProcessClientEncoded(_ *Context, _ *[]byte) {}
func (NopProcessor) ProcessFlush(_ *Context) {}
func (NopProcessor) ProcessPreTransfer(_ *Context, _ *string, _ *string) {}
func (NopProcessor) ProcessTransferFailure(_ *Context, _ *string, _ *string) {}
func (NopProcessor) ProcessPostTransfer(_ *Context, _ *string, _ *string) {}
func (NopProcessor) ProcessCache(_ *Context, _ *[]byte) {}
func (NopProcessor) ProcessDisconnection(_ *Context, _ *string) {}
func (NopProcessor) ProcessStartGame(_ *Context, _ *minecraft.GameData) {}
func (NopProcessor) ProcessServer(_ *Context, _ *packet.Packet) {}
func (NopProcessor) ProcessServerEncoded(_ *Context, _ *[]byte) {}
func (NopProcessor) ProcessClient(_ *Context, _ *packet.Packet) {}
func (NopProcessor) ProcessClientEncoded(_ *Context, _ *[]byte) {}
func (NopProcessor) ProcessFlush(_ *Context) {}
func (NopProcessor) ProcessPreTransfer(_ *Context, _ *string, _ *string) {}
func (NopProcessor) ProcessTransferFailure(_ *Context, _ *string, _ *string) {}
func (NopProcessor) ProcessPostTransfer(_ *Context, _ *string, _ *string) {}
func (NopProcessor) ProcessCache(_ *Context, _ *[]byte) {}
func (NopProcessor) ProcessDisconnection(_ *Context, _ *string) {}
func (NopProcessor) ProcessPreFallback(_ *Context, _ *string, _ *string) {}
func (NopProcessor) ProcessFallbackFailure(_ *Context, _ *string, _ *string, _ error) {}
func (NopProcessor) ProcessPostFallback(_ *Context, _ *string, _ *string) {}
15 changes: 15 additions & 0 deletions session/session.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,15 +321,30 @@ func (s *Session) fallback() error {
return errors.New("already in fallback")
}

s.serverMu.RLock()
origin := s.serverAddr
s.serverMu.RUnlock()

processorCtx := NewContext()

addr, err := s.discovery.DiscoverFallback(s.client)
if err != nil {
s.Processor().ProcessFallbackFailure(processorCtx, &origin, nil, err)
return fmt.Errorf("discovery failed: %w", err)
}

s.Processor().ProcessPreFallback(processorCtx, &origin, &addr)
if processorCtx.Cancelled() {
return errors.New("processor failed")
}

s.logger.Debug("transferring session to a fallback server", "addr", addr)
if err := s.Transfer(addr); err != nil {
s.Processor().ProcessFallbackFailure(processorCtx, &origin, &addr, err)
return fmt.Errorf("transfer failed: %w", err)
}

s.Processor().ProcessPostFallback(processorCtx, &origin, &addr)
return nil
}

Expand Down