-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed a bug #3
Open
coolguyzone
wants to merge
70
commits into
firebasepromise
Choose a base branch
from
master
base: firebasepromise
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fixed a bug #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed local variables - using firebase db calls for all interactions NOTE: known bug, refreshVisualPiles does not work correctly when clicking take pile buttons
- Created a parent div container - Moved buttons above piles
- Added styling for card-pile-container - Changed margin to 0 for card-pile
Firebase integration
Fixed the case where the draft pool runs out of cards
Added an element to show which player's pick it currently is
…lex boxes, and moved around some html elements
Fixed cards remaining and player turn update, changed card piles to f…
Added functionality to disable buttons for empty piles
removed breaking =
cards open in new tab when clicked
…to update in real time
refactored so that last picks work and piles are cleared
Got listener to refresh correctly in multiple versions of app
made cube updates
Got the very basic functionality for a cube upload working, still needs a lot of validation work and error handling
The cube dropdown list now populates with cubes users have added to the db.
Cube names are now automatically populated from the backend.
…breaking the app, will investigate later. Updated h1 text.
420 refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.