Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show proper error message on invalid Git source #2567

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

matpratta
Copy link

This PR fixes an issue when deploying Git repositories with Docker Compose, where the error message would incorrectly say the docker-compose.yaml file was not found instead of saying the Git source is invalid.

It should also resolve my previous issue #2563

One potential improvement here would be to do the same check everywhere that involves a Git source, possibly even before creating the Resource itself.

Copy link

sentry-io bot commented Jun 16, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: app/Models/Application.php

Function Unhandled Issue
App\Models\Application::setGitImportSettings ErrorException: Attempt to read property "is_git_submodules_enabled" on null /app/Models/Application.php in Illuminate\Foundation\Bootstrap\H...
Event Count: 7

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants