Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: special character could break storage settings #2700

Open
wants to merge 9 commits into
base: next
Choose a base branch
from

Conversation

alexzvn
Copy link
Contributor

@alexzvn alexzvn commented Jun 27, 2024

Always use next branch as destination branch for PRs, not main

This PR handle characters set of " ' < > | ? * : and "`" present in storage path.

Copy link

sentry-io bot commented Jun 27, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: app/Models/LocalFileVolume.php

Function Unhandled Issue
App\Models\LocalFileVolume::saveStorageOnServer ErrorException: Attempt to read property "uuid" on null /app/Models/ServiceApplication.php in Illuminate\Foundation\Bootstrap\HandleExceptions::hand...
Event Count: 49
App\Models\LocalFileVolume::saveStorageOnServer ErrorException: Attempt to read property "uuid" on null /app/Models/ServiceDatabase.php in Illuminate\Foundation\Bootstrap\HandleExceptions::hand...
Event Count: 14
App\Models\LocalFileVolume::saveStorageOnServer Error: Call to a member function workdir() on null /app/Models/LocalFileVolume.php in App\Models\LocalFileVolume::saveStorageOnServ...
Event Count: 5

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants