-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
added rybbit service template #6631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @zehjotkah, thanks for the PR!
This looks great, especially for your first PR on GitHub. Definitely better than most service template PRs I’ve seen!
I’ve left a few suggestions to improve the service compose, so please check those out when you get a chance.
Also, it seems like this hasn't been tested yet (based on your comment here. If that’s the case, could you please test it thoroughly and let us know?
Additionally, it would be awesome if you could add a PR to the docs repo here: coolify-docs. You can take a look at this PR for an idea of which files to edit or add.
templates/compose/rybbit.yaml
Outdated
| - 'NEXT_PUBLIC_DISABLE_SIGNUP=${DISABLE_SIGNUP:-false}' | ||
| depends_on: | ||
| - rybbit_backend | ||
| restart: unless-stopped |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coolify adds restart policy automatically so this is not needed
| restart: unless-stopped |
templates/compose/rybbit.yaml
Outdated
| volumes: | ||
| postgres_data: | ||
| clickhouse_data: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coolify adds this automatically so this is not needed
| volumes: | |
| postgres_data: | |
| clickhouse_data: |
templates/compose/rybbit.yaml
Outdated
| timeout: 10s | ||
| retries: 3 | ||
| start_period: 10s | ||
| restart: unless-stopped |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coolify adds restart policy automatically so this is not needed
| restart: unless-stopped |
templates/compose/rybbit.yaml
Outdated
| interval: 30s | ||
| timeout: 10s | ||
| retries: 3 | ||
| restart: unless-stopped |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coolify adds restart policy automatically so this is not needed
| restart: unless-stopped |
templates/compose/rybbit.yaml
Outdated
|
|
||
| rybbit_clickhouse: | ||
| image: 'clickhouse/clickhouse-server:25.4.2' | ||
| container_name: rybbit-clickhouse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coolify adds container names automatically so this is not needed
| container_name: rybbit-clickhouse |
templates/compose/rybbit.yaml
Outdated
| services: | ||
| rybbit: | ||
| image: 'ghcr.io/rybbit-io/rybbit-client:latest' | ||
| container_name: rybbit-client |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coolify adds container names automatically so this is not needed
| container_name: rybbit-client |
templates/compose/rybbit.yaml
Outdated
| timeout: 10s | ||
| retries: 3 | ||
| start_period: 10s | ||
| restart: unless-stopped |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coolify adds restart policy automatically so this is not needed
| restart: unless-stopped |
templates/compose/rybbit.yaml
Outdated
| - CLICKHOUSE_USER=default | ||
| - CLICKHOUSE_DB=analytics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the user and db is already hard coded on rybbit_clickhouse service we don't have to hard code it here (in future if we need to change these value we just need to change in one place)
| - CLICKHOUSE_USER=default | |
| - CLICKHOUSE_DB=analytics | |
| - CLICKHOUSE_USER=${CLICKHOUSE_USER} | |
| - CLICKHOUSE_DB=${CLICKHOUSE_DB} |
templates/compose/rybbit.yaml
Outdated
| - POSTGRES_DB=analytics | ||
| - POSTGRES_USER=frog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the user and db is already hard coded on rybbit_postgres service we don't have to hard code it here (in future if we need to change these value we just need to change in one place)
| - POSTGRES_DB=analytics | |
| - POSTGRES_USER=frog | |
| - POSTGRES_DB=${POSTGRES_DB} | |
| - POSTGRES_USER=${POSTGRES_USER} |
| environment: | ||
| - NODE_ENV=production | ||
| - 'NEXT_PUBLIC_BACKEND_URL=${SERVICE_URL_RYBBIT}' | ||
| - 'NEXT_PUBLIC_DISABLE_SIGNUP=${DISABLE_SIGNUP:-false}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The port: 3000 mentioned on the comments at the top of the compose is useful for users who are using caddy as their Coolify Proxy but those who use traefik as their Coolify Proxy might see no available server error because of the missing SERVICE_URL_RYBBIT_3000
The SERVICE_URL_RYBBIT_3000 also tells Coolify to automatically generate a sub domain for the service with port 3000 at the end so the user just have to change the domain to the domain they prefer to use but the auto generated domain will work out of the box (if they have DNS configured properly to resolve all of their sub domains to the server where they are deploying this service)
| environment: | |
| - NODE_ENV=production | |
| - 'NEXT_PUBLIC_BACKEND_URL=${SERVICE_URL_RYBBIT}' | |
| - 'NEXT_PUBLIC_DISABLE_SIGNUP=${DISABLE_SIGNUP:-false}' | |
| environment: | |
| - SERVICE_URL_RYBBIT_3000 | |
| - NODE_ENV=production | |
| - 'NEXT_PUBLIC_BACKEND_URL=${SERVICE_URL_RYBBIT}' | |
| - 'NEXT_PUBLIC_DISABLE_SIGNUP=${DISABLE_SIGNUP:-false}' |
- fixed port - removed unnecessary stuff (container_name, restart) - added client/frontend healthcheck - DRY for hardcoded values
|
Thanks, I updated the yaml with your suggestions. Thanks for teaching me. |
|
added pull request for the docs: |
|
Thanks, this unfortunately doesn't work for Rybbit. |
|
is there anything I can do to have this merged? |
|
Hey @zehjotkah just now I tested this service and I am not able to create an account. I can see some 404s on the network tab but no errors on the frontend after clicking "continue" button: Also the page goes blank randomly and I can see more 404s on network tab All the service containers were running healthy and I don't see any error messages on container logs. Could you please test this template again and check if it works for you? Also currently the template is using |
@ShadowArcanist just checking to verify: have you set up the domains as per the instructions? (https://github.com/zehjotkah/coolify-docs/blob/next/docs/services/rybbit.md) |
|
Hi @zehjotkah! 👋 It appears to us that you are either adding a new service or making changes to an existing one. Coolify Docs Repository: https://github.com/coollabsio/coolify-docs |
Oopies! I forgot it my bad :/ It's working fine after following those instructions!! |
|
Please merge already |
|
Thank you for the PR! |




Changes
Issues