-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump React Native to 0.73.x #1698
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexsegura
requested review from
lucasferraro,
r0xsh,
vladimir-8,
Pierre-LHOSTE and
Atala
February 26, 2024 05:47
vladimir-8
approved these changes
Feb 26, 2024
Atala
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- it works on my machine 👍
I needed toyarn install
and install java 17. maybe pierre will have issues check with him?
aslo I am surprised you removed the "debug" stuff for flipper it seems it will be added in the production build but I guess you looked about it already ?
Atala
reviewed
Feb 28, 2024
Pierre-LHOSTE
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1696
Fixes #1677
I had to disable MercadoPago to make it work on Android (see #1697)
I still need to test ticket printing, as I updated
EscPosEncoder
.I will also probably try to bump
react-native-ble-manager